search

smacker / go-tree-sitter

Golang bindings for tree-sitter https://github.com/tree-sitter/tree-sitter
MIT License
447 stars 124 forks source link

Improve updater and Go -> 1.20 #172

Closed asalvi0 closed 3 months ago

asalvi0 commented 3 months ago

Cleaned up the UpdateAll method to reuse Update, should be easier to maintain.

Notes: The additional indirect dependencies in go.sum come from github.com/stretchr/testify after running go mod tidy

smacker commented 3 months ago

hi @asalvi0 ! Thank you! But let's support at least 3 latest versions of go. No everybody migrates immediately :)

asalvi0 commented 3 months ago

hi @asalvi0 ! Thank you! But let's support at least 3 latest versions of go. No everybody migrates immediately :)

@smacker I've downgraded to 1.20; all tests are passing locally.

smacker commented 3 months ago

Could you please update this file https://github.com/smacker/go-tree-sitter/blob/master/.github/workflows/test.yml by removing go1.19 and adding go1.23? Looks like I can't push into your branch. Otherwise the CI will fail.

asalvi0 commented 3 months ago

Could you please update this file https://github.com/smacker/go-tree-sitter/blob/master/.github/workflows/test.yml by removing go1.19 and adding go1.23? Looks like I can't push into your branch. Otherwise the CI will fail.

@smacker done.

smacker commented 3 months ago

thank you!