Is there a plan to make this project fully compatible with rugged?

smacker / libgit2.cr

Crystal-lang binding to libgit2 with interface similar to rugged

MIT License

34 stars 12 forks source link

Is there a plan to make this project fully compatible with rugged? #2

Open zhuangbiaowei opened 5 years ago

zhuangbiaowei commented 5 years ago

e.g.

repo.last_commit.oid return -> String

but，in this lib:

repo.last_commit.target_id.to_s return -> String

smacker commented 5 years ago

The aim is to be as compatible as possible but most probably it will be impossible to archive 100% compatibility. Please also keep in mind that the project is at a very early stage right now.

zhuangbiaowei commented 5 years ago

I am also working on this project recently. If you are interested, I hope to submit PR to you.

https://github.com/zhuangbiaowei/libgit2.cr

bew commented 5 years ago

@zhuangbiaowei Nice work!

Since you did quite a lot of changes, I'd suggest to make multiple small PR for each kind of changes you did. This way the reviewer (@smacker) does have too much code to review and you get better feedback on it.

zhuangbiaowei commented 5 years ago

@bew Thank you for your suggestion.

I am willing to submit some smaller PRs. However, I am more worried about @smacker. It seems that his time is not very certain. In my comments, he will take a long time to reply...