search

smaddis / smad-deploy-azure

Terraform scripts to set up AKS, ACR, KV for Kuksa Cloud (Eclipse Hono) deployment.
MIT License
0 stars 6 forks source link

Add timeout, increase exception handling and clarify naming #64

Closed Nindemic closed 3 years ago

Nindemic commented 3 years ago

Signed-off-by: Nindemic niina.lunden@student.oulu.fi

JouHouFin commented 3 years ago

Can you fix the missing dollar signs (lines 52-53): https://github.com/smaddis/smad-deploy-azure/blob/e7fa9620072102d3d765ff3e6653a023cc40215a/tests/honoscript/send.sh#L46-L53 ?

JouHouFin commented 3 years ago

LGTM.

msrn commented 3 years ago

LGTM