search

smaffer / espvgax

ESP8266 VGA Library for Arduino
160 stars 24 forks source link

Using with Arduino IDE, and ESP-07, pins have wrong labels #4

Open Leoneq opened 5 years ago

Leoneq commented 5 years ago

Hi, when I was testing your library on Atmega 328 (VGAX), everything was fine. But testing it on ESP-07, not NodeMCU, i've changed pins from D7, D2 etc. to GPIO pins (just 13, 5 etc.) Compilator was giving an error, "D13 is not defined" I think you should make 2 versions of library, of define board type in vga.begin(board); Non-advanced users won't know wheres problem.

Anyway, I'm writing an tutorial with using your library :)

witnessmenow commented 5 years ago

I would recommend not passing in the board type into the library. If the pins can not be changed from the ones in the library (i.e. there is some hardware reason the pins need to be these ones), the library should define the pins in GPIO pin format. So for example

#define ESPVGAX_VSYNC_PIN D1

should be changed to

#define ESPVGAX_VSYNC_PIN 5

It will continue to work for the NodeMCU but will also support any other ESP8266 boards

If there is no hardware reason the pins selected are the ones to use, then they should not use defines and be changeable in code (the constructor would be a good place to do this)

Pin mapping from NodeMCU format to GPIO format can be found here

https://escapequotes.net/wp-content/uploads/2016/02/esp8266-wemos-d1-mini-pinout.png

Randalfikcz commented 2 years ago

Hello, I've got the same problem. I changed the pin numbers in library. Now the upload is done without issues, but the screen doesn't turn on.