search

smaho-engineering / esptouch_flutter

ESP-Touch Dart API for Flutter. Platform-specific implementation for Android (Java) and iOS (Objective-C).
https://pub.dev/packages/esptouch_flutter
MIT License
100 stars 34 forks source link

Update examples to use wifi_info and connectivity package #10

Open vincevargadev opened 3 years ago

vincevargadev commented 3 years ago

Issue received in email:

HI, Sir as I was going through the documentation and trying to figure it out to work I would like to inform you that the connectivity package has been updated and the breaking change is (The getWifiName, getWifiBSSID and getWifiIP are removed to wifi_info_flutter). Also sir I would really be thankful if you could suggest to me that I should put the GET wifi code in the wifi_info.dart file in your example code. Thanks for your help and Thankyou for working on getting esptouch to flutter 🙌

See changelog in the connectivity package:

2.0.0 [Breaking Change] The getWifiName, getWifiBSSID and getWifiIP are removed to wifi_info_flutter.

ducnguyenenterprise commented 3 years ago

@vargavince91 Do we need update package for the compatibility with connectivity package ? or it just the example issue ?

vincevargadev commented 3 years ago

@ducnguyenenterprise This is only about updating the example so that it uses the latest versions of its dependencies.

guyluz11 commented 2 years ago

Another deprecations wifi_info_flutter --> network_info_plus

This plugin has been replaced by the Flutter Community Plus Plugins version, network_info_plus.

connectivity --> connectivity_plus

This plugin has been replaced by the Flutter Community Plus Plugins version, connectivity_plus.

@vincevargadev I don't see any usage for them in the example, only comments talking about using https://github.com/smaho-engineering/esptouch_flutter/blob/64832e7fc5bffa23e5d69d0a5c0268a614cd8f45/example/README.md?plain=1#L85it. Did you mean that or have I missed something?.

And @ducnguyenenterprise just to understand better, was something WiFi details are missing from connectivity or were it just convenient because you tested it with the other code.

platform-specific code that fetches the WiFi details instead of using the connectivity plugin.