smaitch / Grail

World of Warcraft addon to provide a database of quest information.
31 stars 20 forks source link

Lore map merge #19

Closed puggan closed 7 years ago

puggan commented 7 years ago

Grail.loremasterQuests, merge insted of replacing, when more then one achivment in the same zone Issue #15

Usaly code other lang, so not so into LUA yet, but tested to do a merge to solve the issue.

puggan commented 7 years ago

Bug: Inserts duplicates

smaitch commented 7 years ago

I made a change that should make this not needed. Thank you though because it basically is the right idea.

puggan commented 7 years ago

Ah, you build your own merge-function :-) https://github.com/smaitch/Grail/commit/3b282e5c4bfc362893eba9979ad90cfec5b5d29d#diff-b51851729a957f98ad4905f14a9288b9

Looks like it going to work, if I have time to continue my Loremaster tonight(CET), I'll test it then.

Thanks