smaitch / Grail

World of Warcraft addon to provide a database of quest information.
31 stars 19 forks source link

Alliance and a Horde PRE for non-Faction quest #262

Closed Hendo72 closed 3 years ago

Hendo72 commented 3 years ago

image Go With The Flow|QID|13877| is the Alliance quest Thunder Peak|QID|13879| is the Horde quest

Hot Lava|QID|13880| and Put Out The Fire|QID|13884| have no Faction filter

Can Grail not distinguish between a Horde and an Alliance toon?

smaitch commented 3 years ago

I am not sure what your concern is. Grail knows whether you are Alliance or Horde. Grail is configured so quest 13880 requires either 13877 or 13879 to be completed before being available. The same for quest 13884. So if you are Alliance and have completed 13877, Grail should say 13880 and 13884 are available for you. Likewise, if you are Horde and you have completed 13879, 13880 and 13884 should be available to you. I do not know the meaning of the WoWPro messages you see, but I would read them to say "Grail says quest 13880 has a prerequisite of either 13877 or 13879, but this WoWPro guide only has a prerequisite of 13879". If my interpretation is correct, I would imagine the guide you are using is tailored (or at least the part you are using) to Horde, and the message you are getting is really a red herring, since I would imagine WoWPro indicates the availability of the quests, as also Grail does. Grail attempts to determine with one set of rules the prerequisites for a quest, and sometimes that can be quite complicated. WoWPro seems to do a similar thing, and it seems will optimize those rules based on whatever guide you are using (perhaps specifically to class, race, etc.). Therefore it is logical that there would be a discrepancy between the generic Grail rule and a specific rule optimized for a known set of parameters.

Hendo72 commented 3 years ago

I've spoken with Ludo and he (lazy) needs to make some code changes on his end. I wasn't sure which addon was throwing the error.

Thank you for looking into it.

On Sat, Feb 6, 2021 at 6:35 PM Scott Harrison <

wrote:

Preview: I am not sure what your concern is. Grail knows whether you a --> SPAM? CLICK to BLOCK https://dnt.abine.com/#/block_email/ctkbkqu32f9z@opayq.com/

This email is Masked using Blur - it was sent from github.com to ctkbkqu32f9z@opayq.com (your reply stays Masked). To protect your privacy https://www.abine.com/faq.html#caniaddcc, do not forward this message, or add new recipients like CCs or BCCs.

Thanks for being a Blur customer! If you haven't yet, [ Try DeleteMe at a discount. https://joindeleteme.com/?utm_source=blur&utm_medium=email&utm_campaign=blur-offer ]

I am not sure what your concern is. Grail knows whether you are Alliance or Horde. Grail is configured so quest 13880 requires either 13877 or 13879 to be completed before being available. The same for quest 13884. So if you are Alliance and have completed 13877, Grail should say 13880 and 13884 are available for you. Likewise, if you are Horde and you have completed 13879, 13880 and 13884 should be available to you. I do not know the meaning of the WoWPro messages you see, but I would read them to say "Grail says quest 13880 has a prerequisite of either 13877 or 13879, but this WoWPro guide only has a prerequisite of 13879". If my interpretation is correct, I would imagine the guide you are using is tailored (or at least the part you are using) to Horde, and the message you are getting is really a red herring, since I would imagine WoWPro indicates the availability of the quests, as also Grail does. Grail attempts to determine with one set of rules the prerequisites for a quest, and sometimes that can be quite complicated. WoWPro seems to do a similar thing, and it seems will optimize those rules based on whatever guide you are using (perhaps specifically to class, race, etc.). Therefore it is logical that there would be a discrepancy between the generic Grail rule and a specific rule optimized for a known set of parameters.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/smaitch/Grail/issues/262#issuecomment-774560146, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJOWMVRUWNFYRXY3THJBRE3S5XGZZANCNFSM4XGUJHZQ .

-- And on the eighth day God said, "Ok Murphy, you take over."

smaitch commented 3 years ago

Don't pick on Ludo. I think he is probably buried in snow at the moment. :-)