smaitch / Grail

World of Warcraft addon to provide a database of quest information.
31 stars 19 forks source link

Wow Classic/TBC problems #281

Closed Nerillida closed 3 years ago

Nerillida commented 3 years ago

I downloaded those files that you mentioned in

https://github.com/smaitch/Grail/issues/278#issue-905030970

It seems to work well, BUT, some low level quest are displayed with a level of 255

Screen Shot 2021-05-31 at 16 38 30

Not sure if this is a Wholly or Grail problem.

Thanks

smaitch commented 3 years ago

Normally this would be a Grail problem. I have not done any work with the new Grail in Classic to get the proper levels based on that code. However, I will see what I can do.

Nerillida commented 3 years ago

Thanks, interesting that the completed quests ae 255, others not altered. mybe a clue.

smaitch commented 3 years ago

I just checked on the Classic PTR and the quests are showing up as expected (though I have not checked completed quests).

smaitch commented 3 years ago

I just checked with the starting quests for a level 58 on Classic PTR and completed quests are showing the levels as expected.

smaitch commented 3 years ago

I just checked with a starter character on Classic PTR in Teldrassil and it seems to be performing as expected.

Screen Shot 2021-05-31 at 13 46 21
Nerillida commented 3 years ago

Sorry, no change, deleted Saved variables, Wholly's and Grail's

Here's another example. Seems to have 255 for the level, required level OK

Only for completed quests, but not all of them.

would look but haven idea where to start. Another sample.

Screen Shot 2021-05-31 at 19 20 30

smaitch commented 3 years ago

I logged into live Classic Burning Crusade seems to be ok as well.

Are you saying some of the quests that are completed show their proper level, and some show level 255?

Nerillida commented 3 years ago

Yes

Screen Shot 2021-05-31 at 19 41 42 Screen Shot 2021-05-31 at 19 41 56 Screen Shot 2021-05-31 at 19 42 09 Screen Shot 2021-05-31 at 19 42 22 Screen Shot 2021-05-31 at 19 42 22 Screen Shot 2021-05-31 at 19 42 37 Screen Shot 2021-05-31 at 19 42 50 Screen Shot 2021-05-31 at 19 43 05

All others 255 completed.

smaitch commented 3 years ago

Can you attach your Grail.lua saved variables file for someone that shows this UI? For example, quest 344 shown above in the latest Grail has the level code L5144 which translates as levels 20 and 24 as expected.

Nerillida commented 3 years ago

Here's the saved variables for the one I screen shotted above, bear in mind that it's "new".

Grail.lua.zip

smaitch commented 3 years ago

Actually that is for the character. Can you send me the one for the account, and not a specific character? What I am looking for specifically should be in entries in the file called "learned", which are not in the file associated with a specific character.

Nerillida commented 3 years ago

Here, different accounts are played, so it may reflect this

Grail.lua.zip

smaitch commented 3 years ago

I think if you exit WoW, remove that file from your system, then restart WoW things should appear properly. The issue is you have a recording using the old level format that has been changed. That old format when interpreted using the new system makes the 255 level. Basically you have a line in the file that marks quest 344 with level code L6399 instead of the one Grail has of L5144. Your file will override Grail's data because your file is what you have learned. However, you learned some things in an older version of Grail. There is code in Grail that should have handled that properly, but now I need to see what is happening as it seems not to be in your case.

smaitch commented 3 years ago

I see the problem. I did not implement the old style code....it still is a TODO in the Grail file.

Nerillida commented 3 years ago

Ahh, maybe, there have been too many years played. I will try it.

Surely easier to tell people to delete their old file.

smaitch commented 3 years ago

Yeah, that is usually easier. But I prefer to try to do the work so people can just use the tool without worry. I want to make things simple from that point of view.

Nerillida commented 3 years ago

Very creditable.

Yes, it's fine now. Thanks for your time.

While I have your attention - would it be possible to add the outland maps to Wholly/Grail and a Wholly selector?

I can work on the data files myself.

Grateful for your time. Questie is fine but too different for me. And they don't handle things as well as you.

smaitch commented 3 years ago

I just pushed a change that should allow the Outland continent option, etc. However, we do not have any quests in any of the zones at this time. Any work you do for them will be appreciated. Thanks.

Nerillida commented 3 years ago

Thanks very much. again.

smaitch commented 3 years ago

I pushed a change that should let your old saved variables file to be processed and not turn quests into level 255 quests.

Nerillida commented 3 years ago

Thanks

Trying to get Outland Belf/Draenei areas to show in Wholly.

smaitch commented 3 years ago

I just pushed a change to support Draenei and Blood Elf. However, the zones (the two Isles, Gohostlands, etc.) were already there.

smaitch commented 3 years ago

To list the zones in the Wholly panel you probably need to use the Wholly preferences to show empty zones (as there are no quests in Grail in any of those zones currently).

Nerillida commented 3 years ago

Thanks, I'll stop bothering you for a while. :)

Nerillida commented 3 years ago

Fixed. Thanks.