smaitch / Grail

World of Warcraft addon to provide a database of quest information.
31 stars 19 forks source link

Issue with Grail with DragonFlight pre-patch #315

Closed DoomMachine closed 1 year ago

DoomMachine commented 1 year ago

The following error is being logged:

36x Interface/AddOns/Grail/Grail.lua:1472: attempt to call global 'GetFriendshipReputation' (a nil value)
[string "@Interface/AddOns/Grail/Grail.lua"]:1472: in function `?'
[string "@Interface/AddOns/Grail/Grail.lua"]:11821: in function `_Tooltip_OnEvent'
[string "@Interface/AddOns/Grail/Grail.lua"]:12382: in function <Interface/AddOns/Grail/Grail.lua:12382>

Locals:
self = <table> {
 QuestBreadcrumbsFor = <function> defined @Interface/AddOns/Grail/Grail.lua:10214
 bitMaskClassPriest = 256
 IsBugged = <function> defined @Interface/AddOns/Grail/Grail.lua:7758
 bitMaskGenderMale = 8192
 _RecordArtifactLevels = <function> defined @Interface/AddOns/Grail/Grail.lua:10980
 bitMaskCompleted = 1
 tooltip = com_mithrandir_grailTooltip {
 }
 professionCategoryIdMapping = <table> {
 }
 QuestLocationsAccept = <function> defined @Interface/AddOns/Grail/Grail.lua:10538
 IsAvailable = <function> defined @Interface/AddOns/Grail/Grail.lua:7740
 NO_SKILL = -1
 _HandleEventGarrisonBuildingActivated = <function> defined @Interface/AddOns/Grail/Grail.lua:7422
 bitMaskClassAll = 268443644
 bitMaskQuestUnused4 = 33554432
 _HandleEventLootClosed = <function> defined @Interface/AddOns/Grail/Grail.lua:7450
 bitMaskQuestLegendary = 4096
 _RemoveDelayedNotification = <function> defined @Interface/AddOns/Grail/Grail.lua:5706
 _LevelGainedQuestCheckObserve = <function> defined @Interface/AddOns/Grail/Grail.lua:10234
 reputationFriends = <table> {
 }
 NPC_TYPE_BY = "BY"
 GetNPCInformation = <function> defined @Interface/AddOns/Grail/Grail.lua:7271
 NPC_TYPE_DROP = "DROP"
 _GetWeeklyDay = <function> defined @Interface/AddOns/Grail/Grail.lua:7162
 _MarkQuestType = <function> defined @Interface/AddOns/Grail/Grail.lua:6105
 receivedCalendarUpdateEventList = false
 bitMaskClassDeathKnight = 4
 QuestNPCPrerequisiteTurnins = <function> defined @Interface/AddOns/Grail/Grail.lua:10712
 _ProcessServerBackup = <function> defined @Interface/AddOns/Grail/Grail.lua:9815
 bitMaskQuestVariableLevel = 255
 MeetsRequirementGroup = <function> defined @Interface/AddOns/Grail/Grail.lua:8781
 _EvaluateCodeAsPrerequisite = <function> defined @Interface/AddOns/Grail/Grail.lua:6640
 bitMaskInLog = 16
 bitMaskQuestWeekly = 4
 bitMaskHolidayNoble = 256
 MeetsRequirementProfession = <function> defined @Interface/AddOns/Grail/Grail.lua:8866
 DoesNPCExist = <function> defined @Interface/AddOns/Grail/Grail.lua:6605
 npcNames = <table> {
 }
 diversionMapping = <table> {
 }
 IsCallingQuest = <function> defined @Interface/AddOns/Grail/Grail.lua:8122
 bitMaskQuestFailureWithAncestor = 67043200
 verifyTable = <table> {
 }
 _NPCToUse = <function> defined @Interface/AddOns/Grail/Grail.lua:9157
 garrisonBuildingLevelMapping = <table> {
 }
 bitMaskClassHunter = 16
 _LoadContinentData = <function> defined @Interface/AddOns/Grail/Grail.lua:3468
 bitMaskQuestRaid = 128
 _LocationStructure = <function> defined @Interface/AddOns/Grail/Grail.lua:8330
 _HandleEventAchievementEarned = <function> defined @Interface/AddOns/Grail/Grail.lua:7417
 checksReputationRewardsOnAcceptance = true
 classToMapAreaMapping = <table> {
 }
 verifyTableCount = 0
 _ReputationExceeds = <function> defined @Interface/AddOns/Grail/Grail.lua:11169
 bitMaskRaceUnused9 = 4096
 zonesForLootingTreasure = <table> {
 }
 bitMaskQuestMonthly = 8
 mapAreaBaseClass = 200000
 reputationFriendsMaw = <table> {
 }
 _ContainsAliasNPC = <function> defined @Interface/AddOns/Grail/Grail.lua:6338
 classToBitMapping = <table> {
 }
 FriendshipReputationNameAndLevelName = <function> defined @Interface/AddOns/Grail/Grail.lua:11274
 QuestBreadcrumbs = <function> defined @Interface/AddOns/Grail/Grail.lua:10208
 _UpdateWorldQuestSelfNPC = <function> defined @Interface/AddOns/Grail/Grail.lua:4840
 NPCName = <function> defined @Interface/AddOns/Grail/Grail.lua:9109
 experimental = false
 professionSkillLineIdMapping = <table> {
 }
 bitMaskRaceNightborne = 2
 mapAreaBaseReputation = 400000
 UnregisterObserverQuestStatus = <function> defined @Interface/AddOns/Grail/Grail.lua:11869
 _CleanDatabaseLearnedObjectName = <function> defined @Interface/AddOns/Grail/Grail.lua:4779
 tooltipNPC = com_mithrandir_grailTooltipNPC {
 }
 _FactionsFromQuestGivers = <function> defined @Interface/AddOns/Grail/Grail.lua:8699
 QuestOnAcceptCompletes = <function> defined @Interface/AddOns/Grail/Grail.lua:10724
 bitMaskAncestorLevelTooHigh = 33554432
 bitMaskRaceTroll = 16777216
 bitMaskCanGetUnused2 = 65536
 celebratingHolidayCache = <

I believe as part of this, the Wholly plugin is unable to hook to Grail and display quest data.

yoshimo commented 1 year ago

GetFriendshipReputation is part of the GossipInfo space now:

316

But Wholly seems to need adjustments for the new interface as well : https://github.com/smaitch/Wholly/issues/51

smaitch commented 1 year ago

The call for friendship reputation should now work.