smaitch / Wholly

World of Warcraft addon to present quest information for the user derived from the Grail addon.
23 stars 9 forks source link

Wholly Classic v Retail #27

Closed Nerillida closed 4 years ago

Nerillida commented 4 years ago

I downloaded the latest pair of Wholly/Grail. The file labelled as the Classic version does not do what you state it doe i.e. used more standard colours for the quests in progress. It colours completed as green. and no pin for uncompleted.

I am not sure what "Updates the Classic Wholly quest panel to have a right side." as it always has done so for me, unless we are taking at cross purposes. I used the non-Classicfile, it works fine from map pin point of view.

smaitch commented 4 years ago

Since you were using the older version that has the color as green for complete, you should use the preferences and reset the colors. This should make turnin be yellow, not complete be white and failed be red. If you have a screen shot from the previous version to the current one you can see a slight difference. The main thing is the old version had overlapping textures that could make things not look right if they were applied in the wrong order. The new version should not have that happen.

Nerillida commented 4 years ago

I have found the problem. Or maybe, if I use show quests with prerequisites, the same NPCs quest turn-in pins are hidden by the red exclamation points. A suggestion might be to draw the turn-in pins at a higher level?

But the green completed pins are still there. cccc cccc cccc Wholly preferences Wholly preferences Main Wholly preferences 1 Wholly preferences 2 Wholly preferences 3 Wholly preferences 4 Wholly preferences 5

Quest turn-in obscured Quest turn-in obscured

Quest incomplete Quest incomplete

Quests completed Quests completed

Could it be that yourchangesdidnot "take" on the released version.

tocfile

smaitch commented 4 years ago

I believe the code is correct. The priority is set so a completed quest ready for turn-in has highest priority. The quests that are not complete and failed have the lowest priority. This means if the quest giver that accepts a turn-in has a quest that needs prerequisites, it will appear as a red exclamation point until the quest is ready for turn-in. At that point it will appear as a yellow question mark. The reason this order was chosen was because (1) the most important information should be shown first, and to me that was the completed quest and then other quest information as it has been, (2) the tooltip has the rest of the turn-in quests in it so you can see that the quest giver actually is one you use for turn-in as well (because of the purple quests in the tooltip). The fact that you have a quest that eventually can be turned in was not that important in my thoughts versus there are more quests to get from someone.

To reset the colors did you press this button on the bottom of the main preferences for Wholly?

Screen Shot 2019-11-07 at 17 16 38
Nerillida commented 4 years ago

To reset the colors did you press this button on the bottom of the main preferences for Wholly?

Facepalm