search

smaitch / Wholly

World of Warcraft addon to present quest information for the user derived from the Grail addon.
23 stars 9 forks source link

BfA pre-Patch errors #7

Closed DreamOfHero closed 6 years ago

DreamOfHero commented 6 years ago

Hi, after BfA pre-patch this addon cause 3 errors ingame:

1) Message: Interface\AddOns\Wholly\Wholly.lua:5343: hooksecurefunc(): WorldMapFrame_Update is not a function Stack: Interface\AddOns\Wholly\Wholly.lua:5343: hooksecurefunc(): WorldMapFrame_Update is not a function [C]: in function `hooksecurefunc' Interface\AddOns\Wholly\Wholly.lua:5343: in main chunk

2) Message: (null) this error happen: 21 times, I don't know what it is

3) Message: Binding header WHOLLY is defined more than once in Interface\AddOns\Wholly\Bindings.xml This error happens: 18 times.

I can solve it by myself or I need to wait a newer version of this addon.

Thanks in advance

NERON commented 6 years ago

I think, you should update your grail version

RhapsodySL commented 6 years ago

@NERON Still occurs even with a freshly installed Grail and Wholly. It occurs because an instance of WorldMapFrame_Update still exists in Wholly's code; it's not an issue with Grail.

javierhimura commented 6 years ago

Grail has not been updated to 8.0 yet, i suppose we should wait first for a Grail update

NERON commented 6 years ago

@RhapsodySL if you check wholly code, you will see that Wholly checking Grail.battleForAzeroth before using WorldMapFrame_Update. What version you try to use?

javierhimura commented 6 years ago

@NERON, probably he is using the version available in curseforge, the last version available in curseforge fr both grail and wholly is for 7.3.5

DreamOfHero commented 6 years ago

I install addon only with Twitch desktop. my versions is:

all for wow 7.3.5

funjoker commented 6 years ago

Even the Github Version is not working right now.

The QuestList is empty and Map is broken since Blizzard fucked up with UI hooks

javierhimura commented 6 years ago

Actually i checked the error, the problem is an incorrect sentence in a line of code of the github version of grail

There is a fork in git with a quick fix https://github.com/Koviko/Grail

Whit this change now both github version of grail and wholly work in Pre-Bfa

EDIT: This does not fix everything, as funjoker said map and ui hooks has been changed, it is still broken, but at least with this fix the window for the command /wholly works, it shows the available quest for every zone

smaitch commented 6 years ago

Both Wholly and Grail have been updated for BfA (on the two addon websites and here on GitHub).