search

smali-kazmi / detect-mobile-browser

It is a very simple & small javascript lib to detect all major modern mobile browsers in both backend & frontend
72 stars 21 forks source link

"SmartPhone" -> "Mobile" #3

Open icodeforlove opened 9 years ago

icodeforlove commented 9 years ago

I think you should have chosen "Mobile" as tablets are not phones, other than that this is great :).

Also i find it odd that you are using browser-detector as the bower name, and the entry point is named detect-browser and your namespace is SmartPhone.

We should standardize all of this ;).

smali-kazmi commented 9 years ago

please create a pull request and send me i will accept it after review

Thanks