small-hack / smol-k8s-lab

☁️ CLI & TUI with a smol friendly vibe to get started with Kubernetes on metal, then bootstrap apps using Argo CD 🧸 Great for testing webapps and benchmarking.
https://small-hack.github.io/smol-k8s-lab/
GNU Affero General Public License v3.0
12 stars 1 forks source link

Fix: allow commas in kubelet arg values #135

Closed jessebot closed 8 months ago

jessebot commented 8 months ago

Fixes #132 by adding tabs to the k3s and k3d screen to specifically add kubelet args, instead of accepting them as part of the k3s.yaml file. New TUI screenshot:

Screenshot of smol-k8s-lab TUI k3s config screen showing the bottom box now has a tab for k3s yaml and a tab for kubelet args

The button at the bottom of the third box that says "➕ K3s Option" now can distinguish which tab and section of the yaml it needs to update. When a user enters kubelet-arg as a new option for the k3s.yaml tab, it will gracefully just switch to the correct kubelet args tab.

jessebot commented 8 months ago

test is failing on k3s, but that's due to a lack of isolation of the environments, I think. Will investigate that in a separate issue/PR