search

smallcase / react-native-simple-biometrics

simple interface to verify user authenticity
https://www.npmjs.com/package/react-native-simple-biometrics
MIT License
183 stars 16 forks source link

Title on Android is the touchId fallback text on iOS #12

Closed Reisclef closed 1 year ago

Reisclef commented 1 year ago

There appears to be a bit of a logical oddity around the presentation of the "Title" passed in.

On Android, the title is presented exactly as such i.e.

image

On iOS, the Title is actually used as the fallbackTitle (i.e. Use PIN).

image

I can't imagine a case where a multi-platform app would have the same text in a biometric prompt, as well as the fallback option.

Possible solution might be to hardcode Title to "Use PIN" on iOS for the same behaviour.

Happy to raise a PR for this, but wanted to work out if this was intentional before just raising it.

LonelyCpp commented 1 year ago

hmm yes, setting localizedFallbackTitle to nil makes more sense for ios.

LonelyCpp commented 1 year ago

fixed with https://github.com/smallcase/react-native-simple-biometrics/commit/a6a1b9c53c17baba51aaf06142c8597db3600733