smallcloudai / refact-chat-js

Shared chat code for all IDEs

BSD 3-Clause "New" or "Revised" License

6 stars 0 forks source link

fix(stop chat after cache restore, and ensure tool_use is defined) #128

Closed MarcMcIntosh closed 2 days ago

MarcMcIntosh commented 3 days ago

Pull Request Title

Stop button should work after restoring from cache.

Description

What was the problem?
When the user moves from a chat while it's still streaming and opens it again the stop button no longer works.
How did you solve it?
Added a hash-map for the abort functions which is hoisted into a context object at the top of the app.
Any background context or related links?

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, only code improvements)
[ ] Documentation update

How to Test

Start a chat
Click home.
Click back on the chat.
Click stop, chat should stop.

Also, check that the tool_use property on the thread is retained.

Checklist

[ ] My code follows the code style of this project.
[ ] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have updated the documentation where necessary.

Linked Issues

https://github.com/orgs/smallcloudai/projects/5/views/1?pane=issue&itemId=81525640

Additional Notes