smallcloudai / refact-chat-js

Shared chat code for all IDEs

BSD 3-Clause "New" or "Revised" License

8 stars 0 forks source link

Fix: ToolsContent overflow issue #179

Closed alashchev17 closed 2 weeks ago

alashchev17 commented 3 weeks ago

Fix: ToolsContent overflow issue

Description

Problem: tree() tool in collapsed state was not hiding content which overflows, which led to unexpectedly increased scroll height
Solution: Hiding overflow for collapsible root element
ToolsContent are not hiding overflow inside, if tool content is collapsible

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, only code improvements)
[ ] Documentation update

How to Test

Step 1: Ask in the chat to call tree
Step 2: Expand tool content, then check scroll
Step 3: Click on "Click for more" to expand collapsible, scroll should increase correctly

Checklist

[x] My code follows the code style of this project.
[x] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have updated the documentation where necessary.

MarcMcIntosh commented 3 weeks ago

Would i work with the custom <ScrollArea> component?