smallcloudai / refact-chat-js

Shared chat code for all IDEs

BSD 3-Clause "New" or "Revised" License

8 stars 0 forks source link

Fix tip of the day double next #188

Closed MarcMcIntosh closed 2 weeks ago

MarcMcIntosh commented 2 weeks ago

Tip of the day double next call

Description

Next was being called when the Tip of the day component mounts, causing it to change it's children and remount.

The cases for incrementing the tip have been added to some middleware.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, only code improvements)
[ ] Documentation update

How to Test

Step 1: One a chat and redux dev tools,
Step 2: Click "new chat"
Step 3: tipoftheDay/next should only have been called once.

Screenshots (if applicable)

Checklist

[ ] My code follows the code style of this project.
[ ] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have updated the documentation where necessary.

Linked Issues

Fixes https://refact.fibery.io/Software_Development/UI-chat-js-133#Task/Tip-of-the-day-is-jumping-over-by-one-tip-each-time-we-are-starting-a-new-chat-341

Additional Notes