smallcloudai / refact-chat-js

Shared chat code for all IDEs

BSD 3-Clause "New" or "Revised" License

8 stars 0 forks source link

wip: Make autoscroll opt in. #205

Closed MarcMcIntosh closed 4 days ago

MarcMcIntosh commented 5 days ago

Make auto scroll opt in

Description

auto scrolling when streaming has been causing some issues, making it opt in could provided a better user experience.

This PR replaced the ref to the div to follow when auto scrolling with a ref to the scroll area.

ref.current.scrollIntoView was replaced with mutating ref.current.scrollHeight, it seems to be smoother :)

Along with other refactoring.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactoring (no functional changes, only code improvements)
[ ] Documentation update

How to Test

Start a chat that is gonig to be quite long.
wait until the down arrow button shows up.
click on it to enable following the stream.
wheel up to disable it.
scroll some more.

Screenshots (if applicable)

Checklist

[ ] My code follows the code style of this project.
[ ] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have updated the documentation where necessary.

Linked Issues

https://refact.fibery.io/Software_Development/UI-chat-js-133#Task/Auto-scroll-is-still-broken-384

Additional Notes