Big chat upgrade (replaced by #36)

[Ahmadkhan02]

/claim #28 done with most of the issue but the sidebar part. Do tell if something needs to be changes.

[olegklimov]

I see:

• syntax highlight
• edit in place
• history

[Ahmadkhan02]

I see:

• syntax highlight
• edit in place
• history

also, 1)clicking anywhere on the chat will toggle autoscroll -> code can be copied while answer is streaming 2)diff, new file, copy are now available before streaming is finished. 3)and again on chat being on sidebar, that wouldnt work. Making another sidebar item on vscode primary sidebar will not allow new chat button or the newly added history to work. Also vscode will not allow direct opening of a secondary sidebar via code.

Can you please guide me towards what part of this pull request was dissatisfactory

[olegklimov]

Can you please guide me towards what part of this pull request was dissatisfactory

It's pretty good. CSS needs fixing, but that's minor. I'll have time to play with it more on Friday.

[Ahmadkhan02]

@olegklimov After some research into sidebars in vscode, I learnt that all sidebar webviews are made via vscode.webviewViewProvider class. Hence I was able to bring chat to sidebar. Also added checks for login to it now as it is no longer dependent on the existing sidebar. Also did some css fixes.

[olegklimov]

Looking

[olegklimov]

@Ahmadkhan02 hi, one thing that makes your changes hard to work with: changed whitespace. In src/userLogin.ts there are 700 changed lines, and it's not clear what exactly changed. I'll try to fix it myself...

[olegklimov]

I'm trying to fix it in #35 , but it's hard. In src/extension.ts it looks like an automatic formatting tool was applied.

[Ahmadkhan02]

I'm trying to fix it in #35 , but it's hard. In src/extension.ts it looks like an automatic formatting tool was applied.

I am sorry that that happened. I didnt think auto-formatting will end up in such a issues. Ill give the changes from extension.ts here again though for clarification.

//in imports +import ChatTab from "./chatTab";

//global variables declare global{ ... var chat_panel: ChatTab | undefined; ... }

//change to pressed_call_chat async function pressed_call_chat() { console.log(["pressed_call_chat"]); await vscode.commands.executeCommand("workbench.action.focusChatSideBar"); }

//addition to activate global.chat_panel = new ChatTab( context, new ChatHistoryProvider(context, global.user_logged_in), "" ); let chatView = vscode.window.registerWebviewViewProvider( "refactai-chatSidebar", global.chat_panel, { webviewOptions: { retainContextWhenHidden: true } } ); context.subscriptions.push(chatView);

[olegklimov]

The version that works for me the best is 3d5f0. All the later versions don't do anything if I press "New Chat".

It's not necessary to add another sidebar, that was just a simplification. Also any changes in files unrelated to chat can potentially result in merge conflicts with other branches -- it might become harder to merge.

I think at this point debugging 3d5f0 is the best way to proceed.

This needs some fixing: why two lines, one bold, one regular, why the first line cut early, second line isn't cut at all. "Back" and "x" don't look right.

Problems I found:

• I cannot continue the chat, it resets to empty each time I enter my phrase.
• The highlighted code doesn't match dark blue theme.
• Buttons "New File", "Copy" work before the answer is finished, but I still cannot scroll when the answer is generated.

[Ahmadkhan02]

The version that works for me the best is 3d5f0. All the later versions don't do anything if I press "New Chat". This does start a new chat in the Chat sidebar item for the later versions.

I think at this point debugging 3d5f0 is the best way to proceed.

• I cannot continue the chat, it resets to empty each time I enter my phrase.
• The highlighted code doesn't match dark blue theme.
• Buttons "New File", "Copy" work before the answer is finished, but I still cannot scroll when the answer is generated.

Yes I have the solutions to these issues you mentioned from 3d5f0. But this new commit was the only method I say to have chat implemented on the sidebar. The extension.ts and userLogin.ts files needed to be touched though.

Even if we somehow do with a single sidebar, we would need to remove the entire chatTab.ts code and include it into sidebar.ts logic. This is not a very good approach though

[Ahmadkhan02]

@olegklimov I have covered all these concerns in #36

[ghost]

@Ahmadkhan02 , @olegklimov , this one can be closed.