search

smallcloudai / refact-vscode

Refact AI: Open-source AI Code assistant with autocompletion, chat, refactoring and more for VS Code
https://refact.ai
BSD 3-Clause "New" or "Revised" License
61 stars 19 forks source link

Big chat upgrade #36

Closed Ahmadkhan02 closed 9 months ago

Ahmadkhan02 commented 10 months ago

/claim https://github.com/smallcloudai/refact-vscode/issues/28

new pull request as to not make any conflicts all pendings of #33 covered moved chat to the existing sidebar

olegklimov commented 10 months ago

Can you please 🙏 make less changes in:

747 changes package.json 858 changes src/extension.ts 361 changes src/highlight.ts 1,141 changes src/sidebar.ts 38 changes src/storeVersions.ts

so someone can actually work and understand the changes

Ahmadkhan02 commented 10 months ago

Can you please 🙏 make less changes in:

747 changes package.json 858 changes src/extension.ts 361 changes src/highlight.ts 1,141 changes src/sidebar.ts 38 changes src/storeVersions.ts

so someone can actually work and understand the changes

@olegklimov tried to fix it!! hope Its fine now

Ahmadkhan02 commented 10 months ago

@olegklimov do you need me to re-commit another file?

Ahmadkhan02 commented 10 months ago

@olegklimov please review this and/or tell me more changes if required as I will be busy with some examinations in the upcoming week and it would be very hard for me to do much then.

olegklimov commented 10 months ago

Hi @Ahmadkhan02 sorry to keep you waiting, it was a busy week!

olegklimov commented 10 months ago

Yes, it's much better with unnecessary changes! I'll take a look within a day.

Ahmadkhan02 commented 10 months ago

Yes, it's much better with unnecessary changes! I'll take a look within a day.

I have shifted chat to the main sidebar itself. As I had tried doing a new one for chat before, I find making a new one and maintaining login etc on that more of a hassle. Keep this in mind while reviewing.

Ahmadkhan02 commented 10 months ago

@olegklimov have you started because otherwise I was thinking of some code structure improvements like making both chatTab and chatHistoryProvider singleton

olegklimov commented 10 months ago

I have time today to take a look. No opinion yet, let me look.

olegklimov commented 10 months ago

I think it's fantastic work!

I found a couple of bugs for sure, but it's minor things left.

https://github.com/smallcloudai/refact-vscode/assets/18546213/3c35ac84-095c-4719-a22e-cd34591c7b07

Enter doesn't work when editing, editing leaves funny traces, sometimes "stop generating" doesn't want to go away (end of the video, easy to reproduce by hitting F1)

Ahmadkhan02 commented 10 months ago

@olegklimov

Enter doesn't work when editing, editing leaves funny traces, sometimes "stop generating" doesn't want to go away (end of the video, easy to reproduce by hitting F1)

Made these changes, were quite easy. I had forgotten about adding enter key functionality on retry input. Also made retry unresponsive while stop-button is visible.

Ahmadkhan02 commented 10 months ago

@olegklimov do tell if any other change is required.

olegklimov commented 10 months ago

other change is required I'll merge it into oleg_checking_lsp branch, hopefully tomorrow.