search

smallketchup82 / ketchupbot-updater

epic galxy pedia updator
Creative Commons Attribution Share Alike 4.0 International
1 stars 0 forks source link

Add APIManager implementation #44

Closed smallketchup82 closed 1 month ago

smallketchup82 commented 2 months ago

This PR adds an implementation of APIManager and also adds the corresponding interfaces.

Main difference from the legacy code is that this version uses Axios and AxiosRetry to allow for automatic request retrying if a request fails.

smallketchup82 commented 2 months ago

Okay, I forgot to define the types for TurretData. Don't merge this yet

smallketchup82 commented 2 months ago

nothing seems wrong, but shouldn't there be the api to get the ship data for each ship on the gpedia? anyway, i didnt see a problem with the code currently here

you might be right about that... https://robloxgalaxy.wiki/wiki/Special:CargoTables/ShipData i forgot that i set up cargo on the galaxypedia. it should update everytime an edit occurs on a ship infobox template. we might be able to use that and skip the regex matching. but we'd still have to parse the final data so it might not be worth it.

smallketchup82 commented 2 months ago

okay, actually, im just going to block this pr for the time being. seems like we're going to go with an alternative websocket thing now instead of api requests.

smallketchup82 commented 2 months ago

handing this pr off to @SeaswimmerTheFsh

smallketchup82 commented 1 month ago

taking this back from @SeaswimmerTheFsh