search

smallnest / go-web-framework-benchmark

:zap: Go web framework benchmark
Apache License 2.0
2.06k stars 222 forks source link

issue in benchmark result for go-zero #138

Closed dennissetiawan closed 1 year ago

dennissetiawan commented 2 years ago

Hello , so i was trying to do benchmark for go-zero framework and got some weird result for the benchmark. Can you help to see wether or not something is wrong in the implementation?

Here are the implementation: https://github.com/dennissetiawan/go-web-framework-benchmark

You can see the result in benchmark_trial_1/ and benchmark_trial_2/ folder

vuhoanghiep1993 commented 1 year ago

did the go-zero benchmark result added? I also wating for it, thanks

dennissetiawan commented 1 year ago

benchmark_result_gozero

updated here

dennissetiawan commented 1 year ago

i solved the issue with disabling the default middlewares (check commit in my repo)

vuhoanghiep1993 commented 1 year ago

Thank you for your support but when I compare your result and smallnest result, it not same, may be because of different envirorment when testing, But with benchmark, I think same enviroment is very important,

dennissetiawan commented 1 year ago

yes that's true, my test do not aim to compare it with smallnest's results. We want to compare go-zero with several other frameworks with the expectation in our local environment only with the expectation that if go zero is faster in one environment it would be faster also in another environment also