search

smallnest / rpcx

Best microservices framework in Go, like alibaba Dubbo, but with more features, Scale easily. Try it. Test it. If you feel it's better, use it! 𝐉𝐚𝐯𝐚有𝐝𝐮𝐛𝐛𝐨, 𝐆𝐨𝐥𝐚𝐧𝐠有𝐫𝐩𝐜𝐱! build for cloud!
https://rpcx.io
Other
8.11k stars 1.17k forks source link

RPC Service主动抛非strErr错误 #827

Closed marslabtron closed 11 months ago

marslabtron commented 11 months ago

806

我的理解是最新代码并没有解决 #806 中提出的问题，主要原因是 ServiceError 接口定义的 IsServiceError 方法没有被用到，以下以Failover为例指出相关代码位置：

https://github.com/smallnest/rpcx/blob/5e8665742609e6533a4b61fc4fb618e1139ce771/client/xclient.go#L574-L576

https://github.com/smallnest/rpcx/blob/5e8665742609e6533a4b61fc4fb618e1139ce771/client/xclient.go#L664-L666