search

smallrye / smallrye-context-propagation

SmallRye implementation of MicroProfile Context Propagation
Apache License 2.0
30 stars 24 forks source link

Latest release is not compatible with Java 11 #456

Closed jponge closed 3 months ago

jponge commented 3 months ago

The upgrade from 2.1.0 to 2.1.1 shows a breaking change wrt class files version: https://github.com/smallrye/smallrye-mutiny/pull/1618

/cc @FroMage

FroMage commented 3 months ago

Ah, it had to be compatible with Java 11? The build was previously done on Java 17 though, I thought I had just confirmed what was already the case. Damnit.

Well, I suppose I'll add Java 11 on the test list then.

jponge commented 3 months ago

TBH we should bump to 17 in Mutiny at some point, too

FroMage commented 3 months ago

I'll hold back on releasing a new version because I'm not sure I need other fixes for https://github.com/quarkusio/quarkus/pull/41064

FroMage commented 3 months ago

2.1.2 released for Java 11

jponge commented 3 months ago

We're getting failing tests now :-) https://github.com/smallrye/smallrye-mutiny/actions/runs/9462772708/job/26067209491?pr=1621

FroMage commented 3 months ago

Yeah, we had a similar one in Quarkus, and @cescoffier said it's fine to update the tests :)

Expecting message to be:
  "Failed"
but was:
  "java.lang.RuntimeException: Failed"
jponge commented 3 months ago

Great, I have a plan now 🤣