Added default name for non-runtime included parameters (for JANDEX API), client-side

smallrye / smallrye-graphql

Implementation for MicroProfile GraphQL

Apache License 2.0

160 stars 92 forks source link

Added default name for non-runtime included parameters (for JANDEX API), client-side #2112

Closed mskacelik closed 4 months ago

mskacelik commented 4 months ago

/cc @jmartisk fixes: #2111 Added a default name for parameters not configured to be part of the runtime. The default names are equivalent to the Java Reflection API names (arg0, arg1, arg2,...), so they can be consistent in the GraphQL Request building phase.

I am unsure if tests are necessary since I don't think we have tests for such cases, but I can make them if you wish.

mskacelik commented 4 months ago

Not really sure why Quarkus's tests failed

jmartisk commented 4 months ago

@mskacelik isn't that because the CI tests are still configured to run against your 2.8.2 branch? https://github.com/smallrye/smallrye-graphql/blob/c757c099162d8d4674e7884418693375c990cc33/.github/workflows/build.yml#L99 could you try switching it to the official Quarkus main?