search

smallrye / smallrye-graphql

Implementation for MicroProfile GraphQL
Apache License 2.0
160 stars 92 forks source link

Issue/2068 #2116

Closed robp94 closed 4 months ago

mskacelik commented 4 months ago

I tried to play around with the new implementation in the given reproducer, and it seems that everything works as it should. +1

jmartisk commented 4 months ago

Thanks @robp94 and @mskacelik !!

mskacelik commented 4 months ago

Out of curiosity, does the federation require the interface and its implementors to have the same key identifier?

robp94 commented 4 months ago

Out of curiosity, does the federation require the interface and its implementors to have the same key identifier?

We use it that way, but I never tried it with different keys.

robp94 commented 3 months ago

@jmartisk could we get this in quarkus 3.12.0?

jmartisk commented 3 months ago

@robp94 Sorry, there are some issues with the release pipeline that need fixing first, and 3.12 is already in CR so it's probably too late (the changes in smallrye-graphql 2.9 will be quite big) so I'm rather targeting 3.13 now