search

smallrye / smallrye-health

https://smallrye.io/
Apache License 2.0
53 stars 37 forks source link

Add experimental wellness Health Check procedures #41

Closed antoinesd closed 4 years ago

antoinesd commented 5 years ago

We need to introduce the support for /health/wellness and @Wellness qualifier

Ladicek commented 4 years ago

I think similarly to @Liveness having /health/live and @Readiness having /health/ready, @Wellness should have /health/well.

xstefank commented 4 years ago

@Ladicek it might be, but well as a word is quite overloaded :) I personally don't have a preference.

xstefank commented 4 years ago

@antoinesd do we want to introduce this as experimental or wait for the spec (there are no comments in GG).

antoinesd commented 4 years ago

I think we can wait to have it in the spec. Wdyt?

kenfinnigan commented 4 years ago

We need to be validating ideas in the implementation before we bring them to the spec

xstefank commented 4 years ago

@kenfinnigan do you mean that we shouldn't now add any new API in the spec if it hasn't been already for some time in SR?

kenfinnigan commented 4 years ago

That has been the understanding for a while and made as clear as I and others can over the last 4-5 months.

xstefank commented 4 years ago

yeah, I know but given the timeline, we won't introduce any new features in Health 3.0 if we take this into account, unfortunately. While we still need a breaking release this seems a little harsh trade-off for users.

kenfinnigan commented 4 years ago

Maybe, but that's the approach we're taking.

If we haven't proven that a new API is usable, appropriate, and defined properly, it's premature to add it to a spec