search

smallrye / smallrye-jwt

Apache License 2.0
75 stars 47 forks source link

Add EdDSA to KeyUtils.keyFactoryAlgorithm() #789

Closed Eng-Fouad closed 5 months ago

Eng-Fouad commented 6 months ago

Fixes #788

sberyozkin commented 6 months ago

Thanks @Eng-Fouad, Can you give me a favor and start growing this test, https://github.com/smallrye/smallrye-jwt/blob/main/implementation/common/src/test/java/io/smallrye/jwt/util/KeyUtilsTest.java ? Or maybe it is simpler to add a new test for the JWT token generation, copy and paste https://github.com/smallrye/smallrye-jwt/blob/main/implementation/jwt-build/src/test/java/io/smallrye/jwt/build/JwtSignTest.java#L668

and have the key read from the PEM file ?

Eng-Fouad commented 5 months ago

Thanks @Eng-Fouad, Can you give me a favor and start growing this test, https://github.com/smallrye/smallrye-jwt/blob/main/implementation/common/src/test/java/io/smallrye/jwt/util/KeyUtilsTest.java ? Or maybe it is simpler to add a new test for the JWT token generation, copy and paste https://github.com/smallrye/smallrye-jwt/blob/main/implementation/jwt-build/src/test/java/io/smallrye/jwt/build/JwtSignTest.java#L668

and have the key read from the PEM file ?

Added few tests to KeyUtilsTest.

sberyozkin commented 5 months ago

Thanks @Eng-Fouad They looks good, a minor suggestion to check that it is indeed the right classes that are produced. The main reason I've asked, is that I'm surprised with a 255 key size parameter