search

smallrye / smallrye-jwt

Apache License 2.0
75 stars 47 forks source link

Revert "Fix the Sonar plugin integration" #795

Closed sberyozkin closed 5 months ago

sberyozkin commented 5 months ago

Reverts smallrye/smallrye-jwt#778 for now as it failed the release insisting on improving the coverage, unless we can skip it for the release task only ? Mike, Roberto, what do you think ?

sberyozkin commented 5 months ago

I mean, I do support the idea of the improving the code coverage :-), but I don't have time now to go through all of the smallrye-jwt code to do it just to make a 4.5.2 release :-), hopefully Quarkus 3.11.0.CR1 will pick it up

MikeEdgar commented 5 months ago

@sberyozkin where did you see something about the coverage failing the release? I see here [1] there's an error for unstaged changes.

[1] https://github.com/smallrye/smallrye-jwt/actions/runs/9030492730/job/24814876184

MikeEdgar commented 5 months ago

I think this file needs to be formatted. The release auto-formats it and then git detects the file changed: implementation/common/src/test/java/io/smallrye/jwt/util/KeyUtilsTest.java

sberyozkin commented 5 months ago

Oh, sorry @MikeEdgar, it was the first thing I noticed, the sonar plugin failing, and did not scroll down :-). Now I recall, I did a clean build, and was wondering why was this test code got changed for me... Sorry about the hassle, let me deal with it

MikeEdgar commented 5 months ago

No hassle at all :+1: