search

smallrye / smallrye-opentelemetry

SmallRye OpenTelemetry - A CDI and Jakarta REST implementation of OpenTelemetry Tracing
Apache License 2.0
16 stars 13 forks source link

Jakarta REST Client Span Attributes #315

Open fabrii opened 3 weeks ago

fabrii commented 3 weeks ago

Hello!

Is there a reason for not adding the http.route attribute to client spans name? I see it is not defined in the specification.

In the implementation I see a "TODO" in this line.

Thank you

EDIT:

Just saw that there is an url.template attribute for client name here but is not implemented.

radcortez commented 2 weeks ago

Hi!

Because we are still in version 1.21: https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/http/http-spans.md#name:

HTTP client spans have no http.route attribute since client-side instrumentation is not generally aware of the "route", and therefore HTTP client spans SHOULD use {http.request.method}

Unfortunately, the spec keeps changing definitions in every version, which makes it hard to keep up. We need to upgrade soon.