IncomingJmsMessage assumes message type it won't be empty

[neazevedo]

When used to connect with (legacy activemq server) activemq-client v6.1.1, sending a JMSMessage by default type is "" (empty).

After consuming a JMSMessage JMSType came empty and we try to load type "" from the classloader.

Can we add extra isNotEmpty() validation? Thanks

[neazevedo]

Possible solution:

 IncomingJmsMessage(Message message, Executor executor, JsonMapping jsonMapping) {
        this.delegate = message;
        this.jsonMapping = jsonMapping;
        this.executor = executor;
        String cn = null;
        try {
            cn = message.getStringProperty("_classname");
            if (cn == null) {
                cn = message.getJMSType();
            }
        } catch (JMSException e) {
            // ignore it
        }
        try {
            this.clazz = cn != null && !cn.isEmpty() ? load(cn) : null;
        } catch (ClassNotFoundException e) {
            throw ex.illegalStateUnableToLoadClass(e);
        }

        this.jmsMetadata = new IncomingJmsMessageMetadata(message);
        this.metadata = Metadata.of(this.jmsMetadata);
    }

[cescoffier]

Looks good! Fancy a PR?

[neazevedo]

Yes, can you made me contributor? thanks

[cescoffier]

Hello,

You just need to fork the project in github and then open a pull request.

On Mon 20 May 2024 at 18:06, neazevedo @.***> wrote:

Yes, can you made me contributor? thanks

— Reply to this email directly, view it on GitHub https://github.com/smallrye/smallrye-reactive-messaging/issues/2625#issuecomment-2120755425, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADCG7MFHKC47R3BOBKDWEDZDINSBAVCNFSM6AAAAABH7X57Y2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQG42TKNBSGU . You are receiving this because you commented.Message ID: @.***>

[neazevedo]

done!

Thanks