smallstep / certificates

🛡️ A private certificate authority (X.509 & SSH) & ACME server for secure automated certificate management, so you can use TLS everywhere & SSO for SSH.
https://smallstep.com/certificates
Apache License 2.0
6.35k stars 415 forks source link

make integration tests less flaky #1882

Closed Tantalor93 closed 3 weeks ago

Tantalor93 commented 3 weeks ago

Name of feature:

make the integration tests less flaky on checking the health of running step-ca instance

Pain or issue this feature alleviates:

Why is this important to the project (if not answered above):

it sometimes happens that the server is not started before checking the health of the running server, this is caused by starting the server in a separate goroutine and there is no synchronization before testing the health of the server, it usually passes due to race condition

Is there documentation on how to use this feature? If so, where?

no

In what environments or workflows is this feature supported?

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

CLAassistant commented 3 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.