smallstep / certificates

🛡️ A private certificate authority (X.509 & SSH) & ACME server for secure automated certificate management, so you can use TLS everywhere & SSO for SSH.
https://smallstep.com/certificates
Apache License 2.0
6.8k stars 445 forks source link

wire SkipValidation further into SCEP provisioner #1991

Open mishaslavin opened 2 months ago

mishaslavin commented 2 months ago

Name of feature:

pass SkipValidation further into the SCEP provisioner

Pain or issue this feature alleviates:

When writing custom integrations, some of the validations don't apply, which unintentionally prevents the provisioner from starting up.

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

No additional docs

In what environments or workflows is this feature supported?

Primarily for custom integrations which create their own provisioner/authority objects

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

mishaslavin commented 2 months ago

thanks for the review, I have made the requested changes.

hslatman commented 2 months ago

@mishaslavin one minor linting issue found