smallstep / cli

🧰 A zero trust swiss army knife for working with X509, OAuth, JWT, OATH OTP, etc.
https://smallstep.com/cli
Apache License 2.0
3.57k stars 247 forks source link

[Bug]: Version number mismatch between downloaded deb package and installed #1137

Closed acbekoac closed 3 months ago

acbekoac commented 3 months ago

Steps to Reproduce

adjust the version number within the deb Package

Your Environment

Expected Behavior

The version number shown during "dpki -i" should match the one in the name of the deb package

Actual Behavior

sudo dpkg -i /tmp/step-ca_amd64_0.25.3-rc3.deb (Lese Datenbank ... 34685 Dateien und Verzeichnisse sind derzeit installiert.) Vorbereitung zum Entpacken von .../step-ca_amd64_0.25.3-rc3.deb ... Entpacken von step-ca (0.25.2) über (0.25.2) ... step-ca (0.25.2) wird eingerichtet ...

sudo dpkg -i /tmp/step-cli_amd64_0.25.3-rc3.deb (Lese Datenbank ... 34685 Dateien und Verzeichnisse sind derzeit installiert.) Vorbereitung zum Entpacken von .../step-cli_amd64_0.25.3-rc3.deb ... Entpacken von step-cli (0.25.2) über (0.25.2) ... step-cli (0.25.2) wird eingerichtet ...

Additional Context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

hslatman commented 3 months ago

Hey @acbekoac,

It's possible the mismatch happens due to the -rc3 suffix. The version should be set automatically based on the git tag, and it does seem to do that at least for the binary. We'll cut the v0.26.0 soon, so I'm curious if it'll be set correctly for that.

hslatman commented 3 months ago

Hey @acbekoac, we've released https://github.com/smallstep/cli/releases/tag/v0.26.0 last week. Are you seeing the correct tag now?

acbekoac commented 3 months ago

Hi,

I can see the correct version now - see my script debug below

./check_for_newer_smallstep_version.sh

Issue seems fixed, so case can be closed

thx

hslatman commented 3 months ago

Great, thank you for your report, @acbekoac 🙂 Feel free to reopen in case it happens again.