search

smallstep / helm-charts

Helm packages for Kubernetes
Apache License 2.0
49 stars 73 forks source link

feat: adds caUrl parameter for optional step-certificates service names #103

Closed p-kossa closed 2 years ago

p-kossa commented 2 years ago

Description

This PR adds a caUrl Helm parameter that provides the option of custom step-certificates service names.

This is so that the automatic creation of StepIssuer/StepClusterIssuer via Helm is not limited to the step-certificates service name and URL.

Chart default functionality has not changed as the caUrl default remains the same step-certificates.

Other

README updates to reflect this and previous changes.

p-kossa commented 2 years ago

Hi @p-kossa, it makes sense to add a change to be able to configure the ca URL in the issuer or cluster issuer, but using the name *.caUrl is a little confusing as you're not using it to change the full URL.

I think you can have *.caURL to change the full URL, it can be useful for example if the CA is running on a different cluster. And something like *.caService or *caServiceName to change just the service name, that is what you're doing.

Thanks for the suggestions. I pivoted a bit here - rather than having two separate variables that abstract the URL I kept the default the same instead while providing an optional full CA URL. My motivation behind this was for a use case where a step certificates deployment is in a different namespace. Thoughts?

maraino commented 2 years ago

@p-kossa I want to upgrade the version of step-issuer, I'll create a release when ready.

maraino commented 2 years ago

@p-kossa I've just pushed a new version of the chart with step-issuer v0.6.1