search

smalot / bootstrap-datetimepicker

Both Date and Time picker widget based on twitter bootstrap (supports Bootstrap v2 and v3)
http://www.malot.fr/bootstrap-datetimepicker/
Apache License 2.0
3.49k stars 1.65k forks source link

top #379

Open hezedu opened 9 years ago

hezedu commented 9 years ago

506 line : top=top+document.body.scrollTop is a bug.

delete it

lvshin commented 9 years ago

I have found the same bug today. Is this project still alive?

AuspeXeu commented 9 years ago

Describe why it is a bug. What behaviour can you observe?

Aleksandern commented 9 years ago

You can see this bug on a mobile device...see attached file... bug_datetimepicker

AuspeXeu commented 9 years ago

Which device/browser and do you have the link to the website for me?

Aleksandern commented 9 years ago

Android Opera... You can also use Chrome DevTools device mode (https://developers.google.com/web/tools/setup/device-testing/devtools-emulator), just select Google Nexus 5... Your demo pages doesn't have this bug...

Unfortunately I can't provide a link. However, I can create a new page if you can't catch this bug.

AuspeXeu commented 9 years ago

Well that's hard to grasp then if I cannot reproduce :D

Aleksandern commented 9 years ago

Ok. Give me some time please

AuspeXeu commented 9 years ago

Sure thing :+1:

Aleksandern commented 9 years ago

scroll to bottom of the page... after that click "Start date" or "End date"

http://.../pages/index.html

AuspeXeu commented 9 years ago

Okay. This seems to be buggy in Chrome but works perfectly fine in firefox. Can you patch the website so that it works in chrome by using this comment? 506 line : top=top+document.body.scrollTop

Aleksandern commented 9 years ago

I've commented 537 line

if( !elementOrParentIsFixed(this.element) ){ //top = top + document.body.scrollTop; }

AuspeXeu commented 9 years ago

And then it seems to work on mobile + chrome + firefox. Can you confirm that?

Aleksandern commented 9 years ago

Yes I confirm that.

AuspeXeu commented 9 years ago

Mind filing a pull request for this fix?

Aleksandern commented 9 years ago

You mean I need to create a pull request?

AuspeXeu commented 9 years ago

Yes please

jarstelfox commented 7 years ago

Will be resolved in PR #645, see commit edadb5b47db534e14b498de80978011d4fc5d7df