search

smalot / pdfparser

PdfParser, a standalone PHP library, provides various tools to extract data from a PDF file.
GNU Lesser General Public License v3.0
2.3k stars 534 forks source link

Account for empty arrays in XMP data #624

Closed GreyWyvern closed 11 months ago

GreyWyvern commented 11 months ago

The previous version of Document::extractXMPMetadata() did not account for empty arrays as values. When encountered, use the empty string as a value for this property.

There is no test, because in the future this behaviour might change based on the outcome of #617.

Sorry, I am trying to commit all my small changes before any big ones. :)

k00ni commented 11 months ago

Sorry, I am trying to commit all my small changes before any big ones. :)

A bit off topic: If you plan any bigger changes, we could have a short chat or audio call to coordinate. I really appreciate that you taking the time to improve PFDParser.

k00ni commented 11 months ago

There is no test, because in the future this behaviour might change based on the outcome of https://github.com/smalot/pdfparser/issues/617.

The change is appropriate. Also, I am OK for making an exception in this case, because you have proven to be reliable.