Closed unixnut closed 7 months ago
PHP-CS-Fixer has been run successfully.
All tests passing including new ones in tests/PHPUnit/Integration/EncryptionTest.php
@k00ni Looks like there were pre-existing PHP-CS-Fixer violations in the code; I ignored those because I assumed they were OK. (And just fixed ones in files I added/changed.) Might have come from PR 632 commits.
Any chance you could triage these, please?
@unixnut thank you for this pull request. I am very busy these days, but I will try to get back to you until next week. Only skimmed your code, but it looks great so far.
More re. PHP-CS-Fixer:
src/Smalot/PdfParser/PDFObject.php
is showing up in the list from GitHub actions, but not locally for mesrc/Smalot/PdfParser/Config.php
was my bad, fixedsrc/Smalot/PdfParser/Parser.php
is showing up locally for me (blank_line_before_statement
, line 80 in parseFile()
) but not in the list from GitHub actionssrc/Smalot/PdfParser/RawData/RawDataParser.php
(statement_indentation
, line 405) appears to be spurious, i.e. the correction is badsrc/Smalot/PdfParser/Document.php
(statement_indentation
, line 258): comment line should be moved into else clauseExcept the one I fixed, I believe all of these are out of scope for the PR.
CS related stuff doesn't really matter, because I will clean/correct it myself locally, if needed. The CI stuff is important and there are no problems in your code. Thank you for investing extra time on that :+1:
Hi, @k00ni Sorry to bug you, but it looks like the PR is ready to approve. Any ideas when you will have merged it and released a new version? This is so I can give an update to my client.
Type of pull request
About
In some cases PDF files may be internally marked as encrypted even though the content is not encrypted and can be read.
This MR provides a config option to inform the PDF parser to ignore the encryption and attempt to read the PDF anyway.
This therefore provides a work around for the following issues:
320
488
Thanks to @DivineOmega for making the original pull request.
(PHP-CS-Fixer has not been run.)