Closed GreyWyvern closed 5 months ago
PHP CS Fixer is complaining about indentation in Document.php
, PDFObject.php
and RawData\RawDataParser.php
. Files I didn't even modify. :( Running PHP CS Fixer on my local (Windows) machine doesn't find these issues either.
I merged #670 into master which fixes these coding style issues. Please merge master in to get rid of them.
Thank you!
When a document doesn't include a
BaseEncoding
header,StandardEncoding
should be assumed as the default instead of an empty string.Type of pull request
About
Some documents which are short-and-sweet may not include a
BaseEncoding
header. In this case, the PDF Reference 1.7 describes this encoding as a default.Chapter 5, page 426:
Section 5.5, page 431:
If the result of checking for the
BaseEncoding
returns an empty string, useStandardEncoding
as the value instead. Resolves #665.Checklist for code / configuration changes
fixes #1234
to outline that you are providing a fix for the issue#1234
.