k00ni commented 4 months ago

Type of pull request

[x] New feature (involves code and configuration changes)

About

PHP 8.4 is still in alpha so there is no need to hurry. I wanted to have it integrated already so we can observe changes and how PDFParser behaves.

k00ni commented 2 months ago

@j0k3r What do you think? I saw a few warnings in PHP 8.4 test report and will have a look later on.

k00ni commented 1 month ago

Github has hiccups currently... Saw and still see these errors when running tests. First it seems they all failed but in the end almost all went through.

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules 
          --depth=1 origin +bb7464be22837761d081eb3502fd349ff44c7dde:refs/remotes/pull/723/merge
  remote: git: 'lariat' is not a git command. See 'git --help'.        
  remote: aborting due to possible repository corruption on the remote side.

Bildschirmfoto vom 2024-09-25 16-48-49

Stopped working on the PR for now, because I want to see the hidden warnings when running tests using PHP 8.4 and can't reach test logs because of these weird errors.

k00ni commented 4 weeks ago

Summary:

Nothing spectacular anymore
One adaption required to avoid a warning for array_flip (FYI)
PHPUnit complains about some invalid attributes (I don't really care about that, because its neither PDFParser nor quality related and they changed the config again and again from version to version. We have to use 3 versions for now to cover PHP 7.2 until 8.4, so its normal that we stumble upon deprecations)

In the following the output of PHPUnit (10.x) when running on PHP 8.4 RC2:

Runtime:       PHP 8.4.0RC2
Configuration: /var/www/html/phpunit.xml

...............................................................  63 / 187 ( 33%)
............................................................... 126 / 187 ( 67%)
.............................................................   187 / 187 (100%)

Time: 00:14.655, Memory: 605.75 MB

There was 1 PHPUnit test runner warning:

1) Test results may not be as expected because the XML configuration file did not pass validation:

  Line 5:
  - Element 'include': This element is not expected.

CC @j0k3r Any objection or can we merge it?

j0k3r commented 4 weeks ago

It's ok!

smalot / pdfparser

CI: added PHP 8.4 #723

Type of pull request

About