search

sman591 / homebridge-lg-thinq-ac

Homebridge plugin for LG ThinQ-enabled portable air conditioner
Apache License 2.0
53 stars 16 forks source link

Bugfixes and new feature -- currently testing at home #40

Open jeffmaki opened 4 years ago

jeffmaki commented 4 years ago

Currently testing in my setup via my day-to-day usage. Feel free to join me? LMK if you have any thoughts/feedback?

Fix for sman591#17: confirmed fixed for fahrenheit units, TBD for celsius Fix for sman591#9: duplicate of sman591#17 Fix for sman591#16: requires user to choose in Homebridge UI since HomeKit cannot support custom characteristics (e.g. a switch for this) Fix for sman591#18 Fix for sman591#19 Plus, new feature: display filter cleaning status

sman591 commented 4 years ago

Hey, thanks for contributing! Just glanced through everything and this looks reasonable. I'll try it out locally and give it a full review later -- feel free to convert to a full PR when you're ready.

For the future, please split up each "major" contribution into its own PR. This should be ok for now, but it helps chunk up the review to each relevant change and benefits from automated changelog/release tooling

bluefangs commented 3 years ago

@jeffmaki - Is this something that is still WIP / ongoing testing?

bluefangs commented 3 years ago

I ran this branch to poke out differences. Noticed these in the logs.

[4/19/2021, 9:56:18 PM] [LgThinqAirConditioner] Error during interval update Error: connect ETIMEDOUT 13.124.239.180:46030
[4/19/2021, 9:56:23 PM] [LgThinqAirConditioner] Error during interval update Error: connect ETIMEDOUT 13.124.239.180:46030
[4/19/2021, 9:56:23 PM] [LgThinqAirConditioner] Error during interval update Error: connect ETIMEDOUT 13.124.239.180:46030
[4/19/2021, 9:56:31 PM] [LgThinqAirConditioner] Error during interval update Error: getaddrinfo ENOTFOUND kic-service.lgthinq.com
[4/19/2021, 9:56:32 PM] [LgThinqAirConditioner] Error during interval update Error: getaddrinfo ENOTFOUND kic-service.lgthinq.com
[4/19/2021, 9:56:33 PM] [LgThinqAirConditioner] Error during interval update Error: getaddrinfo ENOTFOUND kic-service.lgthinq.com
[4/19/2021, 9:56:33 PM] [LgThinqAirConditioner] Error during interval update Error: connect ETIMEDOUT 52.79.134.204:46030
[4/19/2021, 9:56:33 PM] [LgThinqAirConditioner] Error during interval update Error: connect ETIMEDOUT 52.79.134.204:46030
[4/19/2021, 9:56:34 PM] [LgThinqAirConditioner] Error during interval update Error: getaddrinfo ENOTFOUND kic-service.lgthinq.com
[4/19/2021, 9:56:36 PM] [LgThinqAirConditioner] Error during interval update Error: getaddrinfo ENOTFOUND kic-service.lgthinq.com
[4/19/2021, 9:56:37 PM] [LgThinqAirConditioner] Error during interval update Error: getaddrinfo ENOTFOUND kic-service.lgthinq.com
[4/19/2021, 9:56:38 PM] [LgThinqAirConditioner] Error during interval update Error: getaddrinfo ENOTFOUND kic-service.lgthinq.com
jbyerline commented 3 years ago

Any word on getting this merged? I have a LG AC with Eco-Mode and would love the addition? Any known bugs since its been a year? @jeffmaki @sman591