smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

wxWidgets patch for tab traversal #195

Closed smanders closed 6 years ago

smanders commented 6 years ago

ConfiguratorGUI Polish - Tab traversal for 'Accounts Page' skips PKI fields https://isrtrac.usurf.usu.edu/trac/isr/ticket/10270

From: Aaron May Sent: Thursday, June 7, 2018 1:39 PM To: Scott M Anderson Subject: Re: wxWidgets 3.1.1

So I found a common trait with the non tab traversable dialogues in linux: If it is disabled in current.cfg, it is not tab traversable regardless of whether I subsequently enable it in the ConfiguratorGUI. If it is enabled in current.cfg, regardless of whether I subsequently disable and enable it in the ConfiguratorGUI it is fully tab traversable. Turns out, this looks an awful lot like a known issue. Here's the ticket for it:http://trac.wxwidgets.org/ticket/16806 . This was fixed about 6 months ago, but it is only present in the 3.1.1 dev release of wxWidgets. We currently use 3.1.0.

I would like to test and see if this issue is resolved using the 3.1.1 wxWidgets dependency. Is there an easy way to do that? Can we build a development externpro for situations like this?​

wxGTK: Unable to tab to controls if they are disabled and later get enabled http://trac.wxwidgets.org/ticket/16806 commit: https://github.com/wxWidgets/wxWidgets/commit/a54d478f0ebf9a7c99071ea62b3544f5ffc1efb9

perhaps we cherry-pick this commit onto our xp3.1.0 branch, for now https://github.com/smanders/wxWidgets/compare/v3.1.0_pkg...xp3.1.0

and create a new issue to update wxWidgets to the 3.1.1 release

smanders commented 6 years ago

completed with commit to dev branch referenced above