search

smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

update cmake required to 3.21 #316

Closed smanders closed 3 years ago

smanders commented 3 years ago

buildpro issue https://github.com/smanders/buildpro/issues/16 updates cmake to 3.21

smanders commented 3 years ago

there is currently a cmake error when requiring cmake 3.20 for the build step ( XP_STEP=build)

CMake Error at /usr/local/share/cmake-3.20/Modules/ExternalProject.cmake:2275 (message):
  ExternalProject 'geotranz' step 'patch' is marked INDEPENDENT but depends
  on step 'geotranz_download_README' that is not marked INDEPENDENT.
Call Stack (most recent call first):
  modules/xpfunmac.cmake:286 (ExternalProject_Add_Step)
  modules/xpfunmac.cmake:263 (ipPatchAdditional)
  modules/xpfunmac.cmake:306 (ipPatch)
  _bld/xpbase/pro/patch.cmake:25 (xpPatchProject)
  modules/macpro.cmake:195 (include)
  CMakeLists.txt:7 (proExecuteStep)

ExternalProject_Add_Step https://cmake.org/cmake/help/v3.20/module/ExternalProject.html#command:externalproject_add_step

it doesn't appear that INDEPENDENT is an option in cmake 3.17 https://cmake.org/cmake/help/v3.17/module/ExternalProject.html#command:externalproject_add_step -- in fact, the 3.20 docs state that it is new in version 3.19

smanders commented 3 years ago

building some externpro projects, the following warning is given

43>CMake Deprecation Warning at CMakeLists.txt:6 (cmake_minimum_required):
43>  Compatibility with CMake < 2.8.12 will be removed from a future version of
43>  CMake.
43>
43>  Update the VERSION argument <min> value or use a ...<max> suffix to tell
43>  CMake that the project does not need compatibility with older versions.
smanders commented 3 years ago

additional cmake error when requiring cmake 3.20 for the mkpatch step (XP_STEP=mkpatch)

-- XP_STEP: mkpatch
CMake Error at /usr/local/share/cmake-3.20/Modules/ExternalProject.cmake:2275 (message):
  ExternalProject 'activemqcpp_3.9.5_repo' step 'update' is marked
  INDEPENDENT but depends on step 'remote_add_upstream' that is not marked
  INDEPENDENT.
Call Stack (most recent call first):
  modules/xpfunmac.cmake:91 (ExternalProject_Add_Step)
  modules/xpfunmac.cmake:114 (ipCloneRepo)
  _bldx/xpbase/pro/mkpatch.cmake:2 (xpCloneProject)
  modules/macpro.cmake:186 (include)
  CMakeLists.txt:7 (proExecuteStep)
smanders commented 3 years ago

completed with commits referenced above