search

smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

boost program_options shared_ptr instead of raw pointer #323

Closed smanders closed 3 years ago

smanders commented 3 years ago

boost 1.67.0 patch https://github.com/smanders/program_options/pull/1 boost 1.76.0 patch https://github.com/smanders/program_options/pull/2 see https://github.com/boostorg/program_options/pull/109 for details

smanders commented 3 years ago

the patch includes both changes to cpp and hpp files, which is different than any of our existing boost patches (all header-only)

so I'll have to see if there is anything different I need to do with SUBDIR and PATCH_STRIP... https://github.com/smanders/externpro/blob/25b462ed70bcb78a2d29b4956f1a816312cc2dd3/projects/boostasio1_67.cmake#L9 https://github.com/smanders/externpro/blob/25b462ed70bcb78a2d29b4956f1a816312cc2dd3/projects/boostasio1_67.cmake#L21

I was pretty sure we'd patched a boost library before that contained both cpp and hpp files, so I went looking through the history -- and it appears we did for boost::iostreams and I broke it out into two patches

but I didn't ever commit the externpro project files that used these patches as it turned out they weren't needed for the "build boost with zlib support" feature

smanders commented 3 years ago

the include/ changes have to be in a separate patch from the src/ and test/ changes because the patches are applied to the boost tar.bz2

smanders commented 3 years ago
smanders commented 3 years ago

completed with commit referenced above