search

smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

xpCommonFlags improvements #338

Closed smanders closed 2 years ago

smanders commented 2 years ago

remove SunOS support -- it's no longer supported and will clean things up if removed

a long time ago (pre-github) there was a project (maybe there still is) that only enabled the C compiler and not C++ and so xpCommonFlags() needed to be rearranged to handle that case https://isrhub.usurf.usu.edu/smanders/externpro/commit/de659881c2c66deb8da982d13f5bda985a8d14d6

now there is a project that only enables C++ and not C and some additional checks and rearranging is necessary (instead of patching the project and enabling C) https://github.com/smanders/flatbuffers/blob/770658c26fb26cef3f26c22dda3776bf5b8572a0/CMakeLists.txt#L23

smanders commented 2 years ago

also, a needed improvement is needed for xpSourceListAppend()... there are now repos that reference the build container from a submodule, so .devcontainer is a symbolic link instead of a directory -- and on windows (linux is fine), the cmake that automatically adds some of our files to the source list needs to be updated to handle this case

smanders commented 2 years ago

completed with commits to dev branch referenced above