search

smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

xpfunmac.cmake improvements #341

Closed smanders closed 2 years ago

smanders commented 2 years ago

xpSourceListAppend() could start adding .github/workflows/*.yml files to the cmake list automatically, modifying this cmake https://github.com/smanders/externpro/blob/22.02/modules/xpfunmac.cmake#L1045-L1071

file(GLOB github_yml ${CMAKE_SOURCE_DIR}/.github/workflows/*.yml)
source_group(github.yml FILES ${github_yml})
list(APPEND ${utility_project}_srcs ${github_yml})

so we don't have to add and maintain these lines in every repo that uses .github/

discussion https://isrhub.usurf.usu.edu/cfrandsen/CommonLibraries/pull/3#pullrequestreview-73682

smanders commented 2 years ago

completed with commit to dev branch referenced above

verified by building CommonLibraries and PlanStore (CommonLibraries is a submodule) and removing the lines from cmake/CMakeLists.txt that manually add the .github/ yml files