search

smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

python dependency #359

Closed smanders closed 2 years ago

smanders commented 2 years ago

the python dependency should be made more prominent

it should probably be a FATAL_ERROR instead of a AUTHOR_WARNING in llvm.cmake https://github.com/smanders/externpro/blob/22.04/projects/llvm.cmake#L24-L28

a similar check should be added for yasm (in it's project/yasm.cmake), as it appears it also requires python https://github.com/yasm/yasm/blob/v1.3.0/ConfigureChecks.cmake#L37-L40

other projects that depend on python should also produce a FATAL_ERROR: nodejs https://github.com/smanders/externpro/blob/22.04/projects/nodejs.cmake#L30-L34

one of these projects didn't like python 3.10.0 on Windows, so maybe the latest release can be checked again and if 3.9.9 is still the latest release supported on Windows a message should indicate that, as well

a related issue is to "document build dependencies" https://github.com/smanders/externpro/issues/25 and maybe this could all happen!

smanders commented 2 years ago

completed with commit to dev branch referenced above