smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

project and patch simplifications, cont'd #362

Closed smanders closed 1 year ago

smanders commented 2 years ago

continue issue https://github.com/smanders/externpro/issues/356

projects

smanders commented 1 year ago

does flatbuffers generate the cmake warning? https://github.com/smanders/externpro/issues/356#issuecomment-1221074788 looks like v2.0.6 still has cmake_minimum_required as 2.8.12 https://github.com/google/flatbuffers/blob/v2.0.6/CMakeLists.txt#L2 later releases use the ...<max> method https://github.com/google/flatbuffers/blob/v2.0.8/CMakeLists.txt#L2

cmake_minimum_required < 3.0

flatbuffers does not generate the warning (and I'm not sure why...) rapidjson currently doesn't build or use the cmake -- externpro just copies headers out of the source

smanders commented 1 year ago

projects that haven't been update yet will be tracked in a future issue completed, for now, with commits referenced above