search

smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

webpro using ipParseDir #377

Closed smanders closed 1 year ago

smanders commented 1 year ago

https://isrhub.usurf.usu.edu/webpro/webpro/pull/572#discussion_r117734 the ip prefix indicates "intended to be used only internally by externpro" https://github.com/smanders/externpro/blob/23.02/modules/xpfunmac.cmake#L4

I was trying to use the ip prefix to indicate these were private cmake functions it appears that webpro has found use for ipParseDir so I should evaluate whether this should be renamed xpParseDir and become an officially supported public cmake function of externpro

smanders commented 1 year ago

also, maybe this should be a separate issue, but just tacking it on to this one since the changes will be in the same file... it appears some projects need to call xpSourceListAppend() twice -- and they shouldn't need to https://isrhub.usurf.usu.edu/jcoppin/CountryCodesServer/pull/4#discussion_r117838

smanders commented 1 year ago

long-term I hope for externpro to become a project with a bunch of cmake... and the project build artifacts will be separate, and the cmake that's part of webpro will be assimilated into externpro -- which would mean that the use of ipParseDir would then be "internally" used again, so as long as the use of ipParseDir is limited to webpro cmake it could remain named ipParseDir and that's what I hope to maintain -- that ipParseDir is for internal-use only and other projects that attempt to use it would be easily flagged and noticed