search

smanikandan14 / ThinDownloadManager

To download files and to avoid using DOWNLOAD_WITHOUT_NOTIFICATION permission if you are using Android's DownloadManager in your apps.
Apache License 2.0
783 stars 185 forks source link

Memory leak #87

Closed wangzhengyi closed 7 years ago

wangzhengyi commented 7 years ago

In DownloadDispatcher.java, mRequest is a global variable. if mRequest set DownloadStatusListenerV1 and DownloadStatusListenerV1 contains Activity instance, this will lead to memory leak. Because gc will not collect mRequest if there is no new request for this Dispatcher. If @smanikandan14 you also think this is a problem, i will create pr for this issue.

I create pr for this issus, link:https://github.com/smanikandan14/ThinDownloadManager/pull/88

smanikandan14 commented 7 years ago

PR Merged. Closing.